Skip to content

Split bandit_feedback to train and test when is_timeseries_split=True #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

nomuramasahir0
Copy link
Contributor

Overview

This PR modifies the output of the obtain_batch_bandit_feedback function in obp/dataset/real.py.
In the current implementation, even if is_timeseries_split=True, one dict containing the key such as ..._test was returned.
In this PR, if is_timeseries_split=True, split to create two dict and return them to users.

Note

The modifications due to the changes in this PR are limited to the scope of test module.
Therefore, for example, for the following file, it is expected that execution will result in an error due to this PR.

if is_timeseries_split:

@usaito
Copy link
Contributor

usaito commented Feb 21, 2021

@nmasahiro Thanks! Can you address the following two points?

I will modify the benchmark scripts later by myself.

@nomuramasahir0
Copy link
Contributor Author

Thank you for the review.

  • I fixed the above points.
  • In addition to this, I remove reward_test from the files.

Could you check it, please?

@usaito
Copy link
Contributor

usaito commented Feb 21, 2021

@nmasahiro Thanks! LGTM!

@usaito usaito merged commit 02f8c89 into st-tech:master Feb 21, 2021
@nomuramasahir0 nomuramasahir0 deleted the split-output-when-timeseries-split branch February 21, 2021 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants