Split bandit_feedback to train and test when is_timeseries_split=True #69
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR modifies the output of the
obtain_batch_bandit_feedback
function inobp/dataset/real.py
.In the current implementation, even if
is_timeseries_split=True
, one dict containing the key such as..._test
was returned.In this PR, if
is_timeseries_split=True
, split to create two dict and return them to users.Note
The modifications due to the changes in this PR are limited to the scope of
test
module.Therefore, for example, for the following file, it is expected that execution will result in an error due to this PR.
zr-obp/benchmark/ope/train_regression_model.py
Line 48 in c870a20