Add calc_ground_truth_policy_value to SyntheticBanditDataset #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nmasahiro Can you review this PR? |
usaito
changed the title
|
@usaito LGTM! |
|
@nmasahiro Thanks! How about this time? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
add
calc_ground_truth_syntheticmethod toSyntheticBanditDatasetclass in the dataset moduleThis will ease the calculation of the ground-truth policy value of evaluation policies when we use synthetic bandit data to conduct the evaluation of OPE experiments
Before
After
codes from https://github.com/st-tech/zr-obp/blob/master/examples/quickstart/synthetic.ipynb
Review points
SyntheticBanditDataset.calc_ground_truth_synthetic