Skip to content

Hotfix: potential error in the fit_predict method of RegressionModel #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 9, 2020

Conversation

usaito
Copy link
Contributor

@usaito usaito commented Nov 9, 2020

In the fit and fit_predict methods of RegressionModel we now have the following undesired error when pscore=None

スクリーンショット 2020-11-10 5 28 44

even if we do not have to set pscore when fitting_method="normal"

In this PR, I fixed the above potential error along with some docstring statements and error messages of the same class.

@usaito usaito merged commit 647f961 into master Nov 9, 2020
@usaito usaito deleted the hotfix/regression-model-fit-predict branch November 9, 2020 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant