Skip to content

Feature: Add subsample option to obp.dataset.OpenBanditDataset #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 11, 2021

Conversation

usaito
Copy link
Contributor

@usaito usaito commented Jul 18, 2021

new feature

  • add sample_size option to the sample_bootstrap_bandit_feedback method of obp.dataset.OpenBanditDataset

    zr-obp/obp/dataset/real.py

    Lines 281 to 283 in e85ba78

    def sample_bootstrap_bandit_feedback(
    self,
    sample_size: Optional[int] = None,

This works as follows.

スクリーンショット 2021-07-18 14 56 19(2)

tests

refactor

  • allow string as the input of data_path as follows

スクリーンショット 2021-07-18 14 51 52(2)

  • fix some english expressions in the docstring

Copy link
Contributor

@fullflu fullflu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m sorry for the delayed response. LGTM other than the [imo] point!

@usaito
Copy link
Contributor Author

usaito commented Aug 11, 2021

@fullflu Thanks for your review!

@usaito usaito merged commit 09c0529 into master Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants