fix ssvmsg MessageIDs to map to a different role #560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GalRogozinski
requested changes
Jul 7, 2025
There was a problem hiding this comment.
Hey!
Thanks for contributing!
As you may have guessed from folder name the jsons are generated.
Can you please:
- revert
- change
types/spectest/tests/ssvmsg/msg_id_belongs.go - change
msg_id_doesnt_belong.go make generate-jsons(there's also a way to not run it for the whole project, but always safer to do it this way)
This reverts commit 4cb3d96.
Comment on lines
+13
to
+14
| types.NewMsgID(testingutils.TestingSSVDomainType, testingutils.TestingWrongValidatorPubKey[:], types.RoleAggregator), | ||
| types.NewMsgID(testingutils.TestingSSVDomainType, testingutils.TestingWrongValidatorPubKey[:], types.RoleAggregator), |
There was a problem hiding this comment.
Suggested change
| types.NewMsgID(testingutils.TestingSSVDomainType, testingutils.TestingWrongValidatorPubKey[:], types.RoleAggregator), | |
| types.NewMsgID(testingutils.TestingSSVDomainType, testingutils.TestingWrongValidatorPubKey[:], types.RoleAggregator), | |
| types.NewMsgID(testingutils.TestingSSVDomainType, testingutils.TestingWrongValidatorPubKey[:], types.RoleAggregator), |
There was a problem hiding this comment.
Now the two messageIDs are duplicated, you can delete one. Same for below and the other test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for test1 and test2 the role is either
invalid, or maps tocommittee.We differentiate between a committee and validator duty executor and enforce that you can only access the public key through the duty executor if the role is not committee. This pr modifies the message ids so that they map to a different role.
Please let me know if we are too strict here. Thanks!