This repository was archived by the owner on Apr 29, 2021. It is now read-only.
report $output content when test fails #8
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -37,6 +37,7 @@ run() { | |||
| set +e | |||
| output="$("$@" 2>&1)" | |||
| status="$?" | |||
| echo "$output" | sed -e 's/^/ #output#/' > "$BATS_OUT" | |||
There was a problem hiding this comment.
👍 this just helped me too, thanks :)
I don't think the sed is necessary, though -- the way I see it, run should behave the same as just invoking the command normally (except that a non-zero exit doesn't fail the test, and that the status and output are captured)
There was a problem hiding this comment.
Although perhaps it should append to $BATS_OUT so that it doesn't overwrite the rest of the test case's output.
|
Thanks for the patch, but I don't think Bats should print Bats will now tell you the test filename and line number that triggers the failure, which should help you when debugging failing tests: bc72b85 |
|
Ah sweet -- that's really helpful. Thanks! |
ntnn
pushed a commit
to ntnn/bats
that referenced
this pull request
Oct 9, 2017
Fix macOS/Bash 3.2 breakage; eliminate subshells from exec-test, preprocess
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in some cases, its not easy to find why test failed. i saw one sollution with custom assert_equal. but its useful to have the content of $output printent out when test fails.
i'm not sure that this is the 100perc correct place, but this worked fine for me and i was able to fix my tests then.