refactor: AutoObserve #6787
Open
refactor: AutoObserve #6787
+201
−135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ab7b1d7.
dageavtobusnick
added
the
testmerge
dageavtobusnick
requested changes
May 16, 2025
| SIGNAL_HANDLER // COMSIG_MOB_UPDATE_SIGHT | ||
| SIGNAL_HANDLER | ||
|
|
||
| if(orbiting && client) |
There was a problem hiding this comment.
Тут ранний ретурн
| continue | ||
| observe.client.screen += worn_item | ||
| else | ||
| LAZYREMOVE(inventory_observers, observe) |
There was a problem hiding this comment.
Тут сделай отрицание условия в if, затем LAZYREMOVE(inventory_observers, observe) и continue, а затем уже все остальное. if(observe.hud_used) тоже проотрицать и сделать continue.
|
Не проверял на локалке изменения, но по идеи ломаться нечему. @dageavtobusnick |
ServerSide14
pushed a commit
to ServerSide14/Paradise
that referenced
this pull request
May 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описание
Переписал с использованием не единого списка орбитеров а с отдельным, в который заносятся мобы что смотрят инвентарь.
Переписал так, что теперь кнопки не прожимаются только когда на госте висит трейт.
Переписал случаи отписки от сигналов на обновление поле зрения.
Поправил замыление экрана.
Поправил удаление хайвмайнд языков у рас, когда те заражаются вавилонской лихорадкой.
Тесты
Потестили с типом на локалке, (почти) всё работает теперь идеально.