tweak: Реворк СЛР #6621
Open
tweak: Реворк СЛР #6621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dageavtobusnick
requested changes
May 16, 2025
| */ | ||
| /mob/living/carbon/proc/pat_out(mob/living/target) | ||
| if(target == src) // stop drop and roll, no trying to put out fire on yourself for free. | ||
| to_chat(src, "<span class='warning'>Stop drop and roll!</span>") |
There was a problem hiding this comment.
используй span_warning, заместо явного указания тега
| H.receiving_cpr_from = null | ||
| return | ||
|
|
||
| visible_message(span_danger("[src] is trying to perform CPR on [H]'s lifeless body!"), span_danger("You start trying to perform CPR on [H]'s lifeless body!")) |
There was a problem hiding this comment.
Если мы что-то меняем/добавляем, текст нужно переводить на русский. Исключение - багфиксы.
| add_attack_logs(src, target, "activated an implanted grenade [G] in [target] with CPR.", ATKLOG_MOST) | ||
| playsound(target.loc, 'sound/weapons/armbomb.ogg', 60, TRUE) | ||
| G.active = TRUE | ||
| addtimer(CALLBACK(G, TYPE_PROC_REF(/obj/item/grenade, prime)), G.det_time) |
There was a problem hiding this comment.
Сделай тут ранние ретурны. if(!условие) return .А со следующей строчки продолжаем то, что делается, если условие выполняется.
| if(target.health >= HEALTH_THRESHOLD_CRIT && !HAS_TRAIT(target, TRAIT_FAKEDEATH)) | ||
| if(target.on_fire) | ||
| user.pat_out(target) | ||
| else if(target.health >= HEALTH_THRESHOLD_CRIT && !HAS_TRAIT(target, TRAIT_FAKEDEATH) && target.stat != DEAD) |
There was a problem hiding this comment.
Тут тоже переделай на ранние ретурны
|
|
||
| H.receiving_cpr_from = null | ||
| visible_message(span_notice("[src] stops performing CPR on [H]."), span_notice("You stop performing CPR on [H].")) | ||
| to_chat(src, span_danger("You need to stay still while performing CPR!")) |
There was a problem hiding this comment.
Вообще прок do_cpr нужно резбить на несколько. Он слишком большой.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описание
Порт вот этого ParadiseSS13/Paradise#21754 вот этого ParadiseSS13/Paradise#23257 и вот этого ParadiseSS13/Paradise#15563
Сердечно-лёгочная Реанимация теперь:
Так же повышен приоритет тушения напарника.
Локализация - локализаторам.
Причина создания ПР / Почему это хорошо для игры
https://discord.com/channels/617003227182792704/755125334097133628/1347830892051304449
Демонстрация изменений
Тесты
Тесты - тестерам.
Тосты - тостерам.