Improved animation for BackStackContainer, PanelContainer. #886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjrjr
force-pushed
the
ray/intentional-animation
branch
from
bbccb73 to
28c6c55
Compare
zach-klippenstein
approved these changes
Jan 17, 2020
...mples/containers/android/src/main/java/com/squareup/sample/container/panel/PanelContainer.kt
Show resolved
Hide resolved
rjrjr
force-pushed
the
ray/intentional-animation
branch
from
28c6c55 to
0e5ad4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@zach-klippenstein demonstrates that dialog based modals can work just fine with tab / IME navigation, and with very simple code. And fixes mismatched speed on default
BackStackContainertransition.