Vend preferredContentSize through the DescribedViewController
#1051
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
zach-klippenstein
added
bug
bencochran
approved these changes
Mar 30, 2020
amorde
approved these changes
Mar 31, 2020
| @@ -0,0 +1,318 @@ | |||
| // | |||
There was a problem hiding this comment.
Nit: we don't use comment headers like this.
Because the `DescribedViewController` wraps all view controllers used in workflows, if it does not vend its current child's `preferredContentSize`, it will be lost. This makes it very difficult to create dynamic workflows that rely on self-sizing view controllers without introducing workarounds to have the children communicate their intended size to the parent, or by removing the convenience of the `DescribedViewController` entirely. This change solves the issue by having the `DescribedViewController` update its own `preferredContentSize` to match whatever the `currentViewController` is, and when that child's size changes.
zradke
force-pushed
the
zradke/preferred-content-size
branch
from
f2def8f to
889a198
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the
DescribedViewControllerwraps all view controllers used inworkflows, if it does not vend its current child's
preferredContentSize, it will be lost. This makes it very difficult tocreate dynamic workflows that rely on self-sizing view controllers
without introducing workarounds to have the children communicate their
intended size to the parent, or by removing the convenience of the
DescribedViewControllerentirely. This change solves the issue byhaving the
DescribedViewControllerupdate its ownpreferredContentSizeto match whatever thecurrentViewControlleris,and when that child's size changes.