Skip to content

Fix #1952 #1953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Fix #1952 #1953

merged 1 commit into from
Jul 30, 2024

Conversation

brokenhappy
Copy link
Contributor

  • docs/changelog.md has been updated if applicable.
  • CLA signed.

Adds additional checks for the presence of initializer block when adding semicolon in an enum class body.
Copy link
Collaborator

@Egorand Egorand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Can you please reword the commit message to be more descriptive? The description you added to changelog.md is perfect, can use a shortened version of it.

@@ -3,6 +3,8 @@ Change Log

## Unreleased

* Fix: Enum classes that only have an init block now also generate the required semicolon (#1952)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Fix: Enum classes that only have an init block now also generate the required semicolon (#1952)
* Fix: Enum classes that only have an init block now also generate the required semicolon (#1953)

@JakeWharton JakeWharton merged commit c0f244a into square:main Jul 30, 2024
4 checks passed
@JakeWharton
Copy link
Collaborator

You can rewrite the commit message after the first click of merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants