Add a mechanism to specify dynamic key-value pairs in the prefill email body of a bug report #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfed
force-pushed
the
federman/bug_report_additions
branch
2 times, most recently
from
e83ab73 to
86869c2
Compare
| @@ -40,6 +51,9 @@ NS_ASSUME_NONNULL_BEGIN | |||
| /// The email body that will be presented to the user when they compose a report. | |||
| @property (nonatomic, copy) NSString *prefilledEmailBody; | |||
|
|
|||
| /// The email body delegate, responsible for providing key/value pairs to include in the bug report at the time the bug is filed. | |||
| @property (nullable, nonatomic) id <ARKEmailBugReporterEmailBodyAdditionsDelegate> emailBodyAdditionsDelegate; | |||
There was a problem hiding this comment.
Should this be weak? I can see arguments for both.
There was a problem hiding this comment.
because there's the possibility of a retain cycle it should be weak. Good catch!
|
LGTM! We should probably write a test for what the email body looks like when there is no email body additions delegate and when there is one returning some keys and values. |
dfed
force-pushed
the
federman/bug_report_additions
branch
2 times, most recently
from
7e3ec3d to
f9644ea
Compare
added 2 commits
September 3, 2015 10:26
dfed
force-pushed
the
federman/bug_report_additions
branch
from
f9644ea to
abe56f1
Compare
dfed
force-pushed
the
federman/bug_report_additions
branch
from
54be3ef to
714abd3
Compare
| @@ -368,6 +370,22 @@ - (void)_dismissEmailComposeWindow; | |||
| } | |||
| } | |||
|
|
|||
| - (NSMutableString *)_prefilledEmailBodyWithEmailBodyAdditions:(nullable NSDictionary *)emailBodyAdditions; | |||
|
Still good! |
dfed
added a commit
that referenced
this pull request
Sep 3, 2015
Add a mechanism to specify dynamic key-value pairs in the prefill email body of a bug report
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @shawnwelch @rhgills @mthole
This should allow us to stop setting the
prefilledEmailBodyat setup time, and start providing key/value pairs on-demand. This will allow us to easily provide the correct user token or wifi network (among other dynamic content) at bug file time.