Skip to content

Bug: Check blocked words against alphabet case-insensitively #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
4kimov opened this issue Aug 31, 2023 · 2 comments
Closed

Bug: Check blocked words against alphabet case-insensitively #4

4kimov opened this issue Aug 31, 2023 · 2 comments
Assignees
@laserpants

Comments

@4kimov
Copy link
Member

4kimov commented Aug 31, 2023

Short version: New bug was found in the spec repo. It was filtering blocklist against the alphabet incorrectly in the constructor, and the issue showed up when using lowercase blocklist in uppercase-only alphabet.

More detailed version: See pull request #7 discussion.

New test was added to the spec: sqids/sqids-spec@02d6116
Code to fix the issue: sqids/sqids-spec@c9c8b28
@laserpants laserpants self-assigned this Aug 31, 2023
@laserpants
Copy link
Collaborator

Fixed in 2838568.

@4kimov
Copy link
Member Author

4kimov commented Aug 31, 2023

💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@laserpants laserpants

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@laserpants @4kimov