feat: Add PulsarTestConsumer #582
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonas-grgt
force-pushed
the
test-consumer
branch
3 times, most recently
from
8c03423 to
9c5596a
Compare
jonas-grgt
force-pushed
the
test-consumer
branch
from
9c5596a to
e8a21ba
Compare
onobc
requested changes
Feb 22, 2024
There was a problem hiding this comment.
This is looking great @jonas-grgt - thank you!
Some minor suggestions, questions, etc.. but other than that I think this one is getting close.
The main shift I had was that after digging in a bit, I think my initial idea of using Awaitility ended up being more trouble than its worth. Mostly because in order to support the "grab as many messages as you can in N time units" use case is super clunky to do. More details can be found in the review comments.
spring-pulsar-test/src/main/java/org/springframework/pulsar/test/support/Condition.java
Outdated
Show resolved
Hide resolved
spring-pulsar-test/src/main/java/org/springframework/pulsar/test/support/Condition.java
Outdated
Show resolved
Hide resolved
spring-pulsar-test/src/main/java/org/springframework/pulsar/test/support/Conditions.java
Outdated
Show resolved
Hide resolved
spring-pulsar-test/src/main/java/org/springframework/pulsar/test/support/Conditions.java
Outdated
Show resolved
Hide resolved
spring-pulsar-test/src/main/java/org/springframework/pulsar/test/support/ConditionsStep.java
Outdated
Show resolved
Hide resolved
...ng-pulsar-test/src/main/java/org/springframework/pulsar/test/support/PulsarTestConsumer.java
Outdated
Show resolved
Hide resolved
...ng-pulsar-test/src/main/java/org/springframework/pulsar/test/support/PulsarTestConsumer.java
Outdated
Show resolved
Hide resolved
...g-pulsar-test/src/main/java/org/springframework/pulsar/test/support/PulsarTestException.java
Show resolved
Hide resolved
...ulsar-test/src/main/java/org/springframework/pulsar/test/support/PulsarTimeOutException.java
Outdated
Show resolved
Hide resolved
spring-pulsar-test/src/main/java/org/springframework/pulsar/test/support/TopicStep.java
Outdated
Show resolved
Hide resolved
onobc
reviewed
Feb 22, 2024
spring-pulsar-test/src/test/java/org/springframework/pulsar/test/support/ConditionTest.java
Outdated
Show resolved
Hide resolved
onobc
requested changes
Feb 24, 2024
There was a problem hiding this comment.
Thanks for the updates @jonas-grgt . Looks great. I think we are on the last round of updates - a few comments to address.
...ulsar-test/src/main/java/org/springframework/pulsar/test/support/PulsarConsumerTestUtil.java
Outdated
Show resolved
Hide resolved
...ulsar-test/src/main/java/org/springframework/pulsar/test/support/PulsarConsumerTestUtil.java
Outdated
Show resolved
Hide resolved
...ulsar-test/src/main/java/org/springframework/pulsar/test/support/PulsarConsumerTestUtil.java
Show resolved
Hide resolved
spring-pulsar-test/src/main/java/org/springframework/pulsar/test/support/Conditions.java
Outdated
Show resolved
Hide resolved
spring-pulsar-test/src/main/java/org/springframework/pulsar/test/support/Conditions.java
Outdated
Show resolved
Hide resolved
spring-pulsar-docs/src/main/antora/modules/ROOT/pages/overview/authors.adoc
Show resolved
Hide resolved
...st/src/test/java/org/springframework/pulsar/test/support/PulsarTestConsumerTestUtilTest.java
Show resolved
Hide resolved
...est/src/test/java/org/springframework/pulsar/test/support/ConsumedMessagesConditionTest.java
Outdated
Show resolved
Hide resolved
spring-pulsar-test/src/test/java/org/springframework/pulsar/test/support/ConditionsTest.java
Outdated
Show resolved
Hide resolved
onobc
added
theme: testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.