Skip to content

Add tests for SpEL attributes on @PulsarListener #549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 23, 2024
Merged

Add tests for SpEL attributes on @PulsarListener #549

merged 6 commits into from
Jan 23, 2024

Conversation

onobc
Copy link
Collaborator

@onobc onobc commented Jan 20, 2024

Resolves #86

@jonas-grgt
Copy link
Contributor

What about expressing topics in @PuslarListener and @PulsarReader through SpEL? I imagine it can be useful as sometimes you want to pre-or-suffix topcis with an environment for example?

@onobc
Copy link
Collaborator Author

onobc commented Jan 21, 2024

The topics and topics-pattern attributes definitely support SpEL, BUT the @PulsarListener javadocs are missing this very important detail. Good catch! I will update the javadocs and ensure test coverage in the scope of this code proposal.

onobc added 3 commits January 21, 2024 21:13
@onobc
Add topics attr to listeners in new SpEL tests
7098009
@onobc
Rename new SpEL test methods
64978af
@onobc
Add tests for other listener SpEL attributes
826f608 
In both @PulsarListener and @ReactivePulsarListener:
* Advertise topics + subscriptionName in Javadocs
* Add topics + subscriptionName SpEL tests
@onobc
Copy link
Collaborator Author

onobc commented Jan 22, 2024

@jonasgeiregat I added docs + tests for topics, topicPattern, and subscriptionName attributes. Take a peek.

@onobc onobc merged commit 645e448 into spring-projects:main Jan 23, 2024
@onobc onobc deleted the GH-86-add-spel-tests branch January 23, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonas-grgt jonas-grgt jonas-grgt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Verify SpEL support on PulsarListener
2 participants
@onobc @jonas-grgt