GH-1961: DefaultDestinationTopicResolver: Inconsistencies In Spring Cloud Environment #1962
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f event source is the same application context.
|
@yvettequinby Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@yvettequinby Thank you for signing the Contributor License Agreement! |
garyrussell
approved these changes
Sep 27, 2021
artembilan
requested changes
Sep 27, 2021
There was a problem hiding this comment.
Thank you for contribution, @yvettequinby !
The fix is indeed correct: only a couple simple refactoring is requested at the moment from me.
Let us know if you can incorporate them or we can do that for you on merge!
...afka/src/main/java/org/springframework/kafka/retrytopic/DefaultDestinationTopicResolver.java
Show resolved
Hide resolved
...src/test/java/org/springframework/kafka/retrytopic/DefaultDestinationTopicResolverTests.java
Show resolved
Hide resolved
garyrussell
pushed a commit
that referenced
this pull request
Sep 27, 2021
|
...and cherry-picked to 2.7.x |
|
@yvettequinby Many thanks for the contribution!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #1961