Skip to content

Change FallbackBatchErrorHandler to Implement CommonErrorHandler Instead of Being Adapted to One #2404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
garyrussell opened this issue Sep 20, 2022 · 0 comments · Fixed by #2406
Closed

Change FallbackBatchErrorHandler to Implement CommonErrorHandler Instead of Being Adapted to One #2404

garyrussell opened this issue Sep 20, 2022 · 0 comments · Fixed by #2406
Assignees
@garyrussell
Labels
type: task
Milestone
3.0.0-RC1

Comments

@garyrussell
Copy link
Contributor

No description provided.

@garyrussell garyrussell added this to the 3.0.0-RC1 milestone Sep 20, 2022
@garyrussell garyrussell self-assigned this Sep 20, 2022
@garyrussell garyrussell changed the title Change FallbackBatchErrorHandler to Implement CommonErrorHandler Instead of Being Adapted Change FallbackBatchErrorHandler to Implement CommonErrorHandler Instead of Being Adapted to One Sep 20, 2022
garyrussell added a commit to garyrussell/spring-kafka that referenced this issue Sep 21, 2022
@garyrussell
spring-projectsGH-2404: Refactor FallbackBatchErrorHandler
c407869 
Resolves spring-projects#2404

- implement `CommonErrorHandler` instead of using an adapter
- populate its retry listeners and log level if needed
- remove listeners thread local in `ErrorHandlingUtils`, needed for previous implementation
- remove final use of `SeekToCurrentBatchErrorHandler` - used in the fallback
  if recovery fails or the thread is interrupted while sleeping
- remove `SeekToCurrentBatchErrorHandler` and its tests
@garyrussell garyrussell mentioned this issue Sep 21, 2022
Merged
garyrussell added a commit to garyrussell/spring-kafka that referenced this issue Sep 21, 2022
@garyrussell
spring-projectsGH-2404: Refactor FallbackBatchErrorHandler
2ceee76 
Resolves spring-projects#2404

- implement `CommonErrorHandler` instead of using an adapter
- populate its retry listeners and log level if needed
- remove listeners thread local in `ErrorHandlingUtils`, needed for previous implementation
- remove final use of `SeekToCurrentBatchErrorHandler` - used in the fallback
  if recovery fails or the thread is interrupted while sleeping
- remove `SeekToCurrentBatchErrorHandler` and its tests
artembilan pushed a commit that referenced this issue Sep 21, 2022
@garyrussell
GH-2404: Refactor FallbackBatchErrorHandler
0da801f 
Resolves #2404

- implement `CommonErrorHandler` instead of using an adapter
- populate its retry listeners and log level if needed
- remove listeners thread local in `ErrorHandlingUtils`, needed for previous implementation
- remove final use of `SeekToCurrentBatchErrorHandler` - used in the fallback
  if recovery fails or the thread is interrupted while sleeping
- remove `SeekToCurrentBatchErrorHandler` and its tests

* Add CTOR to private inner class.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@garyrussell garyrussell

Labels
type: task
Projects
None yet
Milestone
3.0.0-RC1
Development

Successfully merging a pull request may close this issue.

GH-2404: Refactor FallbackBatchErrorHandler garyrussell/spring-kafka
1 participant
@garyrussell