Skip to content

FallbackBatchErrorHandler Does Not Publish Pause/Resume Events #2387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
garyrussell opened this issue Sep 5, 2022 · 2 comments · Fixed by #2420
Closed

FallbackBatchErrorHandler Does Not Publish Pause/Resume Events #2387

garyrussell opened this issue Sep 5, 2022 · 2 comments · Fixed by #2420
Labels
backport 2.8.x (obsolete) backport 2.9.x (obsolete) type: bug
Milestone
3.0.0-M6

Comments

@garyrussell
Copy link
Contributor

https://stackoverflow.com/questions/73571243/records-associated-to-a-kafka-batch-listener-are-not-consumed-for-some-partition/73613322?noredirect=1#comment129993155_73613322
@garyrussell garyrussell added this to the 3.0.0-M6 milestone Sep 5, 2022
@frosiere
Copy link
Contributor

frosiere commented Sep 5, 2022

Pause and resume events should also be fired from KafkaMessageListenerContainer#pauseForNackSleep and KafkaMessageListenerContainer#resumeConsumerIfNeccessary.

garyrussell added a commit to garyrussell/spring-kafka that referenced this issue Sep 6, 2022
@garyrussell
Add Missing Pause/Resume Events
e9887fb 
Resolves spring-projects#2387

- `FallbackBatchErrorHandler`
- `Acknowledgment.nack()`

**2.9.x only - I will back port/forward port**
@garyrussell garyrussell mentioned this issue Sep 6, 2022
Merged
artembilan pushed a commit that referenced this issue Sep 6, 2022
@garyrussell @artembilan
Add Missing Pause/Resume Events
ea6fa8f 
Resolves #2387

- `FallbackBatchErrorHandler`
- `Acknowledgment.nack()`

**2.9.x only - I will back port/forward port**
garyrussell added a commit that referenced this issue Sep 6, 2022
@garyrussell
Add Missing Pause/Resume Events
a190ba7 
Resolves #2387

- `FallbackBatchErrorHandler`
- `Acknowledgment.nack()`

**2.9.x only - I will back port/forward port**
@garyrussell
Copy link
Contributor Author

Pause/Resume events are not published if the container is a ConcurrentMessageListenerContainer (e.g. @KafkaListener).

@garyrussell garyrussell reopened this Sep 29, 2022
garyrussell added a commit to garyrussell/spring-kafka that referenced this issue Sep 29, 2022
@garyrussell
spring-projectsGH-2387: Fix FallbackBatchErrorHandlerEvents
11ba09b 
Resolves spring-projects#2387

Events were not published for `ConcurrentMessageListenerContainer`s.

Also resolves a class tangle in spring-projects#2417
between `ErrorHandlingUtils` and KMLC.
garyrussell added a commit to garyrussell/spring-kafka that referenced this issue Sep 29, 2022
@garyrussell
spring-projectsGH-2387: Fix FallbackBatchErrorHandlerEvents
61a72aa 
Resolves spring-projects#2387

Events were not published for `ConcurrentMessageListenerContainer`s.

Also resolves a class tangle in spring-projects#2417
between `ErrorHandlingUtils` and KMLC.

**cherry-pick to 2.9.x, 2.8.x**
garyrussell added a commit to garyrussell/spring-kafka that referenced this issue Sep 29, 2022
@garyrussell
spring-projectsGH-2387: Fix FallbackBatchErrorHandlerEvents
3858df7 
Resolves spring-projects#2387

Events were not published for `ConcurrentMessageListenerContainer`s.

Also resolves a class tangle in spring-projects#2417
between `ErrorHandlingUtils` and KMLC.

**cherry-pick to 2.9.x, 2.8.x**
garyrussell added a commit to garyrussell/spring-kafka that referenced this issue Sep 29, 2022
@garyrussell
spring-projectsGH-2387: Fix FallbackBatchErrorHandlerEvents
e110ee7 
Resolves spring-projects#2387

Events were not published for `ConcurrentMessageListenerContainer`s.

Also resolves a class tangle in spring-projects#2417
between `ErrorHandlingUtils` and KMLC.

**cherry-pick to 2.9.x, 2.8.x**
garyrussell added a commit to garyrussell/spring-kafka that referenced this issue Sep 29, 2022
@garyrussell
spring-projectsGH-2387: Fix FallbackBatchErrorHandler Events
66d950b 
Resolves spring-projects#2387

Events were not published for `ConcurrentMessageListenerContainer`s.

Also resolves a class tangle in spring-projects#2417
between `ErrorHandlingUtils` and KMLC.

**cherry-pick to 2.9.x, 2.8.x**
@garyrussell garyrussell mentioned this issue Sep 29, 2022
Merged
artembilan pushed a commit that referenced this issue Sep 29, 2022
@garyrussell @artembilan
GH-2387: Fix FallbackBatchErrorHandler Events
b0c1c98 
Resolves #2387

Events were not published for `ConcurrentMessageListenerContainer`s.

Also resolves a class tangle in #2417
between `ErrorHandlingUtils` and KMLC.

**cherry-pick to 2.9.x, 2.8.x**
artembilan pushed a commit that referenced this issue Sep 29, 2022
@garyrussell @artembilan
GH-2387: Fix FallbackBatchErrorHandler Events
5c776cd 
Resolves #2387

Events were not published for `ConcurrentMessageListenerContainer`s.

Also resolves a class tangle in #2417
between `ErrorHandlingUtils` and KMLC.

**cherry-pick to 2.9.x, 2.8.x**

# Conflicts:
#	spring-kafka/src/main/java/org/springframework/kafka/listener/ErrorHandlingUtils.java
#	spring-kafka/src/test/java/org/springframework/kafka/listener/FallbackBatchErrorHandlerIntegrationTests.java
artembilan pushed a commit that referenced this issue Sep 29, 2022
@garyrussell @artembilan
GH-2387: Fix FallbackBatchErrorHandler Events
f6cbf11 
Resolves #2387

Events were not published for `ConcurrentMessageListenerContainer`s.

Also resolves a class tangle in #2417
between `ErrorHandlingUtils` and KMLC.

**cherry-pick to 2.9.x, 2.8.x**

# Conflicts:
#	spring-kafka/src/main/java/org/springframework/kafka/listener/ErrorHandlingUtils.java
#	spring-kafka/src/test/java/org/springframework/kafka/listener/FallbackBatchErrorHandlerIntegrationTests.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backport 2.8.x (obsolete) backport 2.9.x (obsolete) type: bug
Projects
None yet
Milestone
3.0.0-M6
Development

Successfully merging a pull request may close this issue.

GH-2387: Fix FallbackBatchErrorHandler Events garyrussell/spring-kafka
2 participants
@garyrussell @frosiere