Skip to content

Default SimpleAsyncTaskExecutor is Not Reused #1974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
garyrussell opened this issue Oct 5, 2021 · 1 comment · Fixed by #1975
Closed

Default SimpleAsyncTaskExecutor is Not Reused #1974

garyrussell opened this issue Oct 5, 2021 · 1 comment · Fixed by #1975
Assignees
@garyrussell
Labels
type: bug
Milestone
2.8.0-RC1

Comments

@garyrussell
Copy link
Contributor

The child container attempts to save the executor in its properties, but each time the container is started, it gets a new set of properties.
@garyrussell garyrussell added this to the 2.8.0-RC1 milestone Oct 5, 2021
@garyrussell garyrussell self-assigned this Oct 5, 2021
@artembilan
Copy link
Member

See SO for reference: https://stackoverflow.com/questions/69448170/thread-name-convention-in-spring-kafka-concurrentmessagelistenercontainer-consum

garyrussell added a commit to garyrussell/spring-kafka that referenced this issue Oct 5, 2021
@garyrussell
spring-projectsGH-1974: Fix Default Task Executor
7ea4d5e 
Resolves spring-projects#1974

A new `SimpleAsyncTaskExecutor` was created for each child container when
the container was stopped/started.
Reuse the same container for each child; handle an increase to `concurrency` between
stop and start.
@garyrussell garyrussell mentioned this issue Oct 5, 2021
Merged
artembilan pushed a commit that referenced this issue Oct 5, 2021
@garyrussell
GH-1974: Fix Default Task Executor
6287d85 
Resolves #1974

A new `SimpleAsyncTaskExecutor` was created for each child container when
the container was stopped/started.
Reuse the same container for each child; handle an increase to `concurrency` between
stop and start.

* Fix unnecessary bean name null check.

* Fix previous commit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@garyrussell garyrussell

Labels
type: bug
Projects
None yet
Milestone
2.8.0-RC1
Development

Successfully merging a pull request may close this issue.

GH-1974: Fix Default Task Executor garyrussell/spring-kafka
2 participants
@garyrussell @artembilan