Skip to content

MLC - Add isInExpectedState() #1970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
garyrussell opened this issue Oct 4, 2021 · 0 comments · Fixed by #1971
Closed

MLC - Add isInExpectedState() #1970

garyrussell opened this issue Oct 4, 2021 · 0 comments · Fixed by #1971
Assignees
@garyrussell
Labels
type: enhancement
Milestone
2.8.0-RC1

Comments

@garyrussell
Copy link
Contributor

See spring-attic/spring-cloud-stream-binder-kafka#1138 (comment)
@garyrussell garyrussell added this to the 2.8.0-RC1 milestone Oct 4, 2021
@garyrussell garyrussell self-assigned this Oct 4, 2021
@garyrussell garyrussell mentioned this issue Oct 4, 2021
Closed
garyrussell added a commit to garyrussell/spring-kafka that referenced this issue Oct 4, 2021
@garyrussell
spring-projectsGH-1970: Add container.isInExpectedState()
c3bba7f 
Resolves spring-projects#1970

SCSt health check uses `isRunning()` to measure health. However a container
that was `autoStartup=false` (or has been stopped) is healthy, it is just
not running.

- add `isInexpectedState()`
- add `stopAbnormally()`
- call `stopAbnormally` (from `emergencyStop`) when a listener throws an `Error`
- call `stopAbnormally` from the container stopping error handler
garyrussell added a commit to garyrussell/spring-kafka that referenced this issue Oct 4, 2021
@garyrussell
spring-projectsGH-1970: Add container.isInExpectedState()
a31eb1d 
Resolves spring-projects#1970

SCSt health check uses `isRunning()` to measure health. However a container
that was `autoStartup=false` (or has been stopped) is healthy, it is just
not running.

- add `isInexpectedState()`
- add `stopAbnormally()`
- call `stopAbnormally` (from `emergencyStop`) when a listener throws an `Error`
- call `stopAbnormally` from the container stopping error handler
@garyrussell garyrussell mentioned this issue Oct 4, 2021
Merged
artembilan pushed a commit that referenced this issue Oct 4, 2021
@garyrussell
GH-1970: Add container.isInExpectedState()
a8d0313 
Resolves #1970

SCSt health check uses `isRunning()` to measure health. However a container
that was `autoStartup=false` (or has been stopped) is healthy, it is just
not running.

- add `isInexpectedState()`
- add `stopAbnormally()`
- call `stopAbnormally` (from `emergencyStop`) when a listener throws an `Error`
- call `stopAbnormally` from the container stopping error handler

* Fix test.

Stopping one container causes a rebalance which may cause a redelivery.
garyrussell added a commit to garyrussell/spring-kafka that referenced this issue Oct 4, 2021
@garyrussell
spring-projectsGH-1970: Container Stopping EH Improvement
2a19418 
Add an option to stop the container normally.

There might be a case where the container is stopped due to an error, but
the user wants the container to remain 'healthy', e.g. to avoid Kubernetes
restarting the instance.
artembilan pushed a commit that referenced this issue Oct 4, 2021
@garyrussell @artembilan
GH-1970: Container Stopping EH Improvement
56c0587 
Add an option to stop the container normally.

There might be a case where the container is stopped due to an error, but
the user wants the container to remain 'healthy', e.g. to avoid Kubernetes
restarting the instance.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@garyrussell garyrussell

Labels
type: enhancement
Projects
None yet
Milestone
2.8.0-RC1
Development

Successfully merging a pull request may close this issue.

GH-1970: Add container.isInExpectedState() garyrussell/spring-kafka
1 participant
@garyrussell