-
Notifications
You must be signed in to change notification settings - Fork 472
Fix custom media type parser documentation #1475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix custom media type parser documentation #1475
Conversation
3a0d086
to
47181fe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, if it's a single media type, then parseMediaType()
is the one you want. parseMediaTypes
is for handling a comma-separated list of media types.
Thanks for the feedback @gregturn. The Would you rather I change it to something like this? return Collections.singletonList(MediaType.parseMediaType("application/vnd-acme-media-type")); |
Documentation for `HypermediaMappingInformation.getMediaTypes` expects to return a `List<MediaType>` which is not shown in the ref docs. Amend it with a proper parsing API as well as formatting.
Thanks @kylehoehns for bringing this up. We'll take it from here. |
Resolved via ce36fee. |
Documentation for `HypermediaMappingInformation.getMediaTypes` expects to return a `List<MediaType>` which is not shown in the ref docs. Amend it with a proper parsing API as well as formatting. See: #1475.
@kylehoehns Would you mind to share with us which media-type you implement and if it will be available for the public? :) |
@ingogriebsch I was implementing a custom media type for an internal application that just dealt with versioning. We ended up registering media types for |
Noticed a slight error with the documentation while implementing my own custom media type for a project recently. Thanks!