Skip to content

Wrong nullability declarations for with…(…) method parameter of Link #2084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tgeens opened this issue Jan 17, 2024 · 1 comment
Closed

Wrong nullability declarations for with…(…) method parameter of Link #2084

tgeens opened this issue Jan 17, 2024 · 1 comment
Assignees
@odrotbohm
Labels
in: core Core parts of the project type: enhancement
Milestone
2.3.0-M1

Comments

@tgeens
Copy link
Contributor

tgeens commented Jan 17, 2024

Following up on #1602

The fields hreflang, media, title, type, deprecation, profile, name are nullable and since 55aa4ff correctly annotated with @Nullable 👍

My IDE still gives me warnings for nullability-issues when calling the withXYZ methods with a potential null-value.

Shall I send a PR for this ?
@odrotbohm
Copy link
Member

Sure thing, appreciated! 🙇

@odrotbohm odrotbohm changed the title Wrong nullability declarations for withX method parameter of Link Wrong nullability declarations for with…(…) method parameter of Link Jan 17, 2024
tgeens added a commit to tgeens/spring-hateoas that referenced this issue Jan 18, 2024
@tgeens
spring-projects#2084 nullability for Link with-methods args
d74392c
@tgeens tgeens mentioned this issue Jan 18, 2024
Closed
odrotbohm pushed a commit that referenced this issue Mar 13, 2024
@tgeens @odrotbohm
GH-2084 - Fix nullability declaration for with…(…) methods in Link.
7d8c420 
Original pull request: GH-2088.
odrotbohm added a commit that referenced this issue Mar 13, 2024
@odrotbohm
GH-2084 - Polishing.
fe604e8
@odrotbohm odrotbohm added this to the 2.3.0-M1 milestone Mar 13, 2024
@odrotbohm odrotbohm self-assigned this Mar 13, 2024
@odrotbohm odrotbohm added type: enhancement in: core Core parts of the project labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@odrotbohm odrotbohm

Labels
in: core Core parts of the project type: enhancement
Projects
None yet
Milestone
2.3.0-M1
Development

Successfully merging a pull request may close this issue.

Adds nullable declarations for with…(…) method parameter of Link tgeens/spring-hateoas
2 participants
@odrotbohm @tgeens