Skip to content

UriTemplate can't recognize variable names that contain a dot #1800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alan-mann opened this issue Jun 17, 2022 · 2 comments
Closed

UriTemplate can't recognize variable names that contain a dot #1800

alan-mann opened this issue Jun 17, 2022 · 2 comments
Assignees
Labels
in: core Core parts of the project type: bug
Milestone

Comments

@alan-mann
Copy link

alan-mann commented Jun 17, 2022

to reproduce:

//  work
UriTemplate.of("http://localhost:8201/{?integrations}").getVariableNames().size() // => 1 

// not work
UriTemplate.of("http://localhost:8201/{?integrations.not}").getVariableNames().size() // => 0

As a comparison, the ruby client sporkmonger/addressable parses variables correctly

require 'addressable'
Addressable::Template.new("http://localhost:8201/{?integrations.not}").variables # => ["integrations.not"]

below is a screenshot taken from the RFC(https://datatracker.ietf.org/doc/html/rfc6570#section-2.3):
image

@alan-mann alan-mann changed the title UriTemplat.of can't recognize variable names that contain a dot UriTemplate can't recognize variable names that contain a dot Jun 17, 2022
@odrotbohm odrotbohm self-assigned this Jun 18, 2022
@odrotbohm odrotbohm added type: bug in: core Core parts of the project labels Jun 18, 2022
@odrotbohm odrotbohm added this to the 2.0 M4 milestone Jun 18, 2022
@odrotbohm
Copy link
Member

Fixed and backported to 1.5 and 1.4.

@odrotbohm odrotbohm changed the title UriTemplate can't recognize variable names that contain a dot UriTemplate can't recognize variable names that contain a dot Jun 18, 2022
@alan-mann
Copy link
Author

that's fast. thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core Core parts of the project type: bug
Projects
None yet
Development

No branches or pull requests

2 participants