Skip to content

Change identityprovider to assertingparty in Saml2RelyingPartyProperties #30642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
marcusdacoregio opened this issue Apr 12, 2022 · 1 comment
Closed

Change identityprovider to assertingparty in Saml2RelyingPartyProperties #30642

marcusdacoregio opened this issue Apr 12, 2022 · 1 comment
Assignees
@mhalbritter
Labels
type: enhancement A general enhancement
Milestone
2.7.0-RC1

Comments

@marcusdacoregio
Copy link

Since this commit in Spring Security, some properties in the RelyingPartyRegistration were deprecated in favor of others aligned SAML 2.0 Spec Language.

Consider changing identityprovider in favor of assertingparty in Saml2RelyingPartyProperties to better align with the naming in Spring Security.

Related:
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Apr 12, 2022
@scottfrederick scottfrederick added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Apr 12, 2022
@scottfrederick scottfrederick added this to the 2.7.x milestone Apr 12, 2022
@mhalbritter mhalbritter self-assigned this Apr 13, 2022
@mhalbritter mhalbritter mentioned this issue Apr 19, 2022
Closed
mhalbritter added a commit to mhalbritter/spring-boot that referenced this issue Apr 19, 2022
@mhalbritter
Rename 'identityprovider' property to 'asserting-party'
21c0b79 
Rename spring.security.saml2.relyingparty.registration.*.identity-provider.*
to spring.security.saml2.relyingparty.registration.*.asserting-party.*

The old property names are still supported, but will lead to a warning
in the logs.

Closes spring-projectsgh-30642
@mhalbritter
Copy link
Contributor

I've added a note to the release notes: https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-2.7.0-RC1-Release-Notes#deprecations-in-spring-boot-27

@snicoll snicoll modified the milestones: 2.7.x, 2.7.0-RC1 Apr 20, 2022
@mhalbritter mhalbritter mentioned this issue Apr 20, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mhalbritter mhalbritter

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
2.7.0-RC1
Development

No branches or pull requests
5 participants
@scottfrederick @snicoll @marcusdacoregio @spring-projects-issues @mhalbritter