This repository was archived by the owner on Jan 19, 2022. It is now read-only.
Merge to 1.1.x: Make Pub/Sub thread pools Spring-managed beans (#1505) #1518
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The two thread pools are hardcoded in autoconfiguration, so they fall through the cracks when a Spring application shuts down:
FixedExecutorProvider.shouldAutoClose()
isfalse
(also, we don't callSubscriberStub.shutdown()
, which we arguably should do, as well.This does not manifest on the publisher side because that thread pool is never started, but the subscriber thread pool is started by way of subscriber stub creation when
PubSubSubscriberTemplate
is instantiated.Cherrypicked from #1505.
Fixes #1503.
Addresses the Pub/Sub part of #1506.