fix: Better error reporting for structure evaluations #189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabriziodemaria
commented
Feb 20, 2025
| @@ -206,7 +216,7 @@ extension FlagResolution { | |||
|
|
|||
| private func getValue(path: [String], value: ConfidenceValue) throws -> ConfidenceValue { | |||
| if path.isEmpty { | |||
| guard value.asStructure() != nil else { | |||
| guard value.asStructure() == nil else { | |||
fabriziodemaria
force-pushed
the
of-object-eval
branch
from
1c9b721 to
4847d31
Compare
fabriziodemaria
changed the title
vahidlazio
previously approved these changes
Feb 20, 2025
Signed-off-by: Fabrizio Demaria <[email protected]>
fabriziodemaria
force-pushed
the
of-object-eval
branch
from
4847d31 to
635e313
Compare
fabriziodemaria
requested review from
mfranberg,
nicklasl and
nickybondarenko
as code owners
fabriziodemaria
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Returning
parseErrorin case of unsupported resolving ofValue "structure"from the OpenFeature Provider. Same forConfidenceValue "structure".The related error message is also clearer now:
Related to #190