Skip to content

refactor(retrofit2): upgrade code to use retrofit2 #1313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Mar 18, 2025
Merged

refactor(retrofit2): upgrade code to use retrofit2 #1313

merged 19 commits into from
Mar 18, 2025

Conversation

alice485
Copy link
Contributor

  • This PR upgrades all code to use retrofit2 and the retrofit2 boilerplate code implemented in kork-retrofit
  • Removes all dependencies to retrofit1
  • Removes all references to retrofit1 and RetrofitError

@dbyron-sf
Copy link
Contributor

@Mergifyio update

@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 12, 2025

update

✅ Branch has been successfully updated

dbyron-sf
dbyron-sf reviewed Mar 12, 2025
View reviewed changes
kirangodishala
kirangodishala reviewed Mar 12, 2025
View reviewed changes
igor-monitor-travis/src/main/java/com/netflix/spinnaker/igor/travis/config/TravisConfig.java Outdated
.setLog(new Slf4jRetrofitLogger(TravisClient.class))
.setErrorHandler(SpinnakerRetrofitErrorHandler.getInstance())
return new Retrofit.Builder()
.baseUrl(address)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you refer this and make sure the address doesn't end up in baseUrl must end in / error. And this is applicable to all such retrofit2 client definitions.

kirangodishala
kirangodishala requested changes Mar 13, 2025
View reviewed changes
Copy link
Contributor

@kirangodishala kirangodishala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alice485 - there are several places where Retrofit2SynCall.execute() is missing. Here are what I found so far:

PluginsBuildMonitor.java

TravisBuildMonitor.java

DockerMonitor.groovy

GitlabCiBuildMonitor.java

JenkinsBuildMonitor.groovy

ConcourseBuildMonitor.java

EchoServiceHealthIndicator.java

HelmMonitor.java

NexusEventPoster.java

@alice485 alice485 force-pushed the upgrade-to-retrofit2 branch from 6d69e8a to 0c4d482 Compare March 13, 2025 20:24
@alice485 alice485 force-pushed the upgrade-to-retrofit2 branch 2 times, most recently from a57dc32 to e196b7f Compare March 14, 2025 20:23
@alice485 alice485 force-pushed the upgrade-to-retrofit2 branch 2 times, most recently from f9c958e to 2b321b2 Compare March 17, 2025 15:25
@alice485 alice485 force-pushed the upgrade-to-retrofit2 branch from 2b321b2 to b56e2f9 Compare March 17, 2025 15:42
@dbyron-sf dbyron-sf added the ready to merge Approved and ready for merge label Mar 18, 2025
@mergify mergify bot added the auto merged label Mar 18, 2025
@dbyron-sf
Copy link
Contributor

Thank you @alice485 ! Could you please add a release note similar to https://spinnaker.io/changelogs/1.37.0-changelog/#retrofit2-upgrade?

@mergify mergify bot merged commit 769f175 into spinnaker:master Mar 18, 2025
4 checks passed
@alice485 alice485 mentioned this pull request Mar 22, 2025
Merged
@sspaeth-r7 sspaeth-r7 mentioned this pull request Apr 25, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kirangodishala kirangodishala kirangodishala approved these changes

@dbyron-sf dbyron-sf dbyron-sf approved these changes

Assignees
No one assigned
Labels
auto merged ready to merge Approved and ready for merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alice485 @dbyron-sf @kirangodishala