Do not override type checks for test_util_fileutil #13552
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamtheturtle
commented
May 13, 2025
|
|
||
| if TYPE_CHECKING: | ||
| from sphinx.testing.util import SphinxTestApp | ||
|
|
||
|
|
||
| class DummyTemplateLoader(BuiltinTemplateLoader): | ||
| class DummyTemplateLoader(BuiltinTemplateLoader, BaseRenderer): |
There was a problem hiding this comment.
Instances of this are given as the renderer parameter to copy_asset_file which is defined with renderer: BaseRenderer | None = None.
AA-Turner
approved these changes
May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.