linkcheck: Ignore URLs that respond with non-Unicode content #12197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…anchor-checking # Conflicts: # doc/usage/configuration.rst # sphinx/builders/linkcheck.py # tests/test_builders/test_build_linkcheck.py
AA-Turner
changed the title
|
@AA-Turner is it OK if we pause on this one for a while? I think/hope it's a good idea, but I'm slightly concerned that the distinction between lenient and strict parsing might be a bit arbitrary. I should perhaps move this back into a draft status. |
|
Another way to phrase that: I'd like to canvas more (and perhaps leaning skeptical) opinions about this before proceeding. |
|
Thanks! |
jayaddison
commented
Jul 10, 2024
…king Conflicts: doc/usage/configuration.rst sphinx/builders/linkcheck.py tests/test_builders/test_build_linkcheck.py
…s recommended by `ruff`.
…tting. Partially reverts commit 3282332.
…king Conflicts: sphinx/builders/linkcheck.py
jayaddison
changed the title
jayaddison
changed the title
AA-Turner
reviewed
Jul 14, 2024
AA-Turner
changed the title
AA-Turner
changed the title
AA-Turner
changed the title
…king # Conflicts: # CHANGES.rst
|
Thanks @AA-Turner! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Bugfix
Purpose
linkcheckdecodes response content.Begin to add more validation of parsed HTML.Detail
ignored.Report hyperlinks as broken when their content fails validation checks, but allow this to be overridden using URI-match patterns.Relates
...pdf#anchor) leads to'utf-8' codec can't decode byte ...#11041.