wallet: RBF batch payments manager #9298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecdsa
force-pushed
the
batch_payments_manager
branch
from
b71b11f to
45c7543
Compare
ecdsa
force-pushed
the
batch_payments_manager
branch
13 times, most recently
from
a48e7ca to
5c7a247
Compare
ecdsa
force-pushed
the
batch_payments_manager
branch
13 times, most recently
from
3bdbf87 to
3ad4406
Compare
|
Note: This PR does not work well with fee settings. When we change the fee settings in |
SomberNight
previously requested changes
Feb 25, 2025
ecdsa
force-pushed
the
batch_payments_manager
branch
from
ccb0cc3 to
3325ca1
Compare
ecdsa
force-pushed
the
batch_payments_manager
branch
12 times, most recently
from
39e40c0 to
7918670
Compare
ecdsa
force-pushed
the
batch_payments_manager
branch
5 times, most recently
from
88a16f1 to
94f4b0b
Compare
SomberNight
reviewed
Mar 11, 2025
ecdsa
force-pushed
the
batch_payments_manager
branch
from
94f4b0b to
d2ece93
Compare
The class TxBatcher handles the creation, broadcast and replacement
of replaceable transactions. Callers (LNWatcher, SwapManager) use
methods add_payment_output and add_sweep_info. Transactions
created by TxBatcher may combine sweeps and outgoing payments.
Transactions created by TxBatcher will have their fee bumped
automatically (this was only the case for sweeps before).
TxBatcher manages several TxBatches. TxBatches are created
dynamically when needed.
The GUI does not touch txbatcher transactions:
- wallet.get_candidates_for_batching excludes txbatcher
transactions
- RBF dialogs do not work with txbatcher transactions
wallet:
- instead of reading config variables, make_unsigned_transaction
takes new parameters: base_tx, send_change_to_lighting
tests:
- unit tests in test_txbatcher.py (replaces test_sswaps.py)
- force all regtests to use MPP, so that we sweep transactions
with several HTLCs. This forces the payment manager to aggregate
first-stage HTLC tx inputs. second-stage are not batched for now.
ecdsa
force-pushed
the
batch_payments_manager
branch
from
d2ece93 to
bdb7a82
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
note: this is not "reorg safe", meaning that there is no guarantee that all payments will end up in in the blockchain.
However, I believe this is "double send safe", meaning that we will never send a payment twice.