Skip to content

chore(yarn): move postinstall to yarn build:public #4793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 22, 2025

Conversation

iainsproat
Copy link
Contributor

@iainsproat iainsproat commented May 21, 2025

Description & motivation

yarn install can take a long time, of which 2 minutes (in CircleCI) is spent in the link/postinstall step.

Part of this link/postinstall script is a postinstall command for frontend-2 package.

As yarn install is called more often than yarn build:public in CI, we hope to reduce some time by moving this postinstall instructions from yarn to the less frequently run yarn build:public command.

DX change: When developing bothyarn and yarn build:public we now expect both commands be run by developers.

Changes:

  • @speckle/frontend-2 postinstall steps are now run via yarn build:public
  • Within package.json, the yarn workspaces foreach flags are now longhand to make them readable.
  • packages/server/.mocharc.js - remove unnecessary search for .spec.js files which no longer exist

To-do before merge:

Screenshots:

Validation of changes:

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

References

Copy link

linear bot commented May 21, 2025

Copy link

codecov bot commented May 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.35%. Comparing base (7b72968) to head (bf5e200).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4793   +/-   ##
=======================================
  Coverage   70.35%   70.35%           
=======================================
  Files         578      578           
  Lines       25022    25022           
  Branches     3729     3729           
=======================================
  Hits        17604    17604           
  Misses       6250     6250           
  Partials     1168     1168           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fabis94 fabis94 marked this pull request as ready for review May 22, 2025 18:06
@iainsproat iainsproat merged commit 05f5ad0 into main May 22, 2025
25 of 27 checks passed
@iainsproat iainsproat deleted the iain/web-3479-reduce-yarn-postinstall-steps branch May 22, 2025 18:15
iainsproat added a commit that referenced this pull request May 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants