feat(ci): gha and blacksmith #4647
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielgak
force-pushed
the
daniel/web-3263-test-yarn-install-caching-in-github-actions
branch
4 times, most recently
from
2559f07 to
8d3fc9b
Compare
danielgak
force-pushed
the
daniel/web-3263-test-yarn-install-caching-in-github-actions
branch
from
8d3fc9b to
08469af
Compare
danielgak
changed the title
danielgak
changed the title
danielgak
force-pushed
the
daniel/web-3263-test-yarn-install-caching-in-github-actions
branch
2 times, most recently
from
31b2f98 to
337e4bd
Compare
danielgak
force-pushed
the
daniel/web-3263-test-yarn-install-caching-in-github-actions
branch
from
337e4bd to
8638fbe
Compare
|
Anchors are not supported actions/runner#1182 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4647 +/- ##
===========================================
- Coverage 70.31% 58.66% -11.66%
===========================================
Files 578 109 -469
Lines 25014 3970 -21044
Branches 3729 488 -3241
===========================================
- Hits 17589 2329 -15260
+ Misses 6257 1613 -4644
+ Partials 1168 28 -1140 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
danielgak
force-pushed
the
daniel/web-3263-test-yarn-install-caching-in-github-actions
branch
from
e5cfc17 to
d29b0c1
Compare
iainsproat
reviewed
May 19, 2025
iainsproat
reviewed
May 19, 2025
danielgak
force-pushed
the
daniel/web-3263-test-yarn-install-caching-in-github-actions
branch
2 times, most recently
from
700f0d6 to
529621d
Compare
iainsproat
reviewed
Jun 6, 2025
iainsproat
reviewed
Jun 6, 2025
danielgak
commented
Jun 6, 2025
Comment on lines
182
to
186
| - docker-build-postgres-container: | ||
| context: *build-context | ||
| filters: *filters-build | ||
| filters: *filters-allow-all | ||
| requires: | ||
| - get-version |
There was a problem hiding this comment.
this one still runs after get-version, so it can be used by multiregion
Comment on lines
+63
to
+70
| - test-server-multiregion: | ||
| context: | ||
| - speckle-server-licensing | ||
| - stripe-integration | ||
| - speckle-server-codecov | ||
| filters: *filters-allow-all | ||
| requires: | ||
| - docker-build-postgres-container |
There was a problem hiding this comment.
this one still runs after docker-build-postgres-container
| @@ -126,66 +136,64 @@ workflows: | |||
| filters: *filters-allow-all | |||
There was a problem hiding this comment.
get-version is still needed in circle ci
iainsproat
previously approved these changes
Jun 6, 2025
utils/postgres/Dockerfile
Outdated
| @@ -22,4 +22,4 @@ COPY --link --from=builder /aiven-extras/aiven_extras.so /usr/local/lib/postgres | |||
|
|
|||
| EXPOSE 5432 | |||
|
|
|||
| CMD ["postgres"] | |||
| CMD ["postgres", "-c", "max_connections=1000", "-c", "wal_level=logical" ] | |||
There was a problem hiding this comment.
In CircleCI multiregion test we no longer strictly require the line command: -c 'max_connections=1000' -c 'wal_level=logical' if this is present here.
But the command in CircleCI replaces the entire CMD statement in the Dockerfile, so no need to make any changes.
.github/workflows/builds.yml
Outdated
| uses: useblacksmith/build-push-action@v1 | ||
| with: | ||
| push: false | ||
| tags: speckle/speckle-test-deployment:${{ inputs.IMAGE_VERSION_TAG }} # TODO: fix tag, |
iainsproat
approved these changes
Jun 6, 2025
danielgak
deleted the
daniel/web-3263-test-yarn-install-caching-in-github-actions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ports the Pull Request jobs from CircleCI to GitHub Actions on Blacksmith runners.
The multi-region test-server job remains in CircleCI as the only job (along with its dependencies get-version and build-postgres-docker-image) triggered by Pull Requests.
Commits to
main,hotfix*andtesting*branches will run on CircleCI as usual.