Skip to content

Bilal/cnx 2013 implement workspace dropdown #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 17, 2025

Conversation

bimgeek
Copy link
Contributor

@bimgeek bimgeek commented Jun 17, 2025

MERGE #285 before this PR.

This PR turns Workspaces dropdown to a button. This is implemented for performance reasons. With this PR:

  • Only active workspace name gets fetched in dialog initialization.
  • Workspaces only gets fetched when switching between them.
  • Workspace class is stored in the window manager instead of two separate fields for workspace id and name.

Rest of the functionality should be same as before. Only change should be project selection dialog would initialize faster.

image
BEFORE
image
AFTER

image

@bimgeek bimgeek requested a review from dogukankaratas June 17, 2025 09:26
Copy link

linear bot commented Jun 17, 2025

@dogukankaratas dogukankaratas merged commit f3e188b into v3-dev Jun 17, 2025
2 checks passed
@dogukankaratas dogukankaratas deleted the bilal/cnx-2013-implement-workspace-dropdown branch June 17, 2025 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants