Skip to content

If Error Message Present SOMETHING IS WRONG #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 22, 2018

Conversation

lloy0076
Copy link
Contributor

...so we should throw an \Exception!

There's no tests for this, per se, but it does work, see:

{
    "message": "OVER_QUERY_LIMIT",
    "exception": "Exception",
    "file": "C:\\laragon\\webroots\\one-calendar\\calendar\\vendor\\spatie\\geocoder\\src\\Geocoder.php",
    "line": 70,
    "trace": [
        {
            "file": "C:\\laragon\\webroots\\one-calendar\\calendar\\vendor\\laravel\\framework\\src\\Illuminate\\Support\\Facades\\Facade.php",
            "line": 221,
            "function": "getCoordinatesForAddress",
            "class": "Spatie\\Geocoder\\Geocoder",
            "type": "->"
        },

Addresses #1 - but I cannot re-open that!

@freekmurze freekmurze merged commit 5d886ef into spatie:master Feb 22, 2018
@freekmurze
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants