Skip to content

refs #0000 Add Cloud SQL monitoring #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2024
Merged

Conversation

osvaldot
Copy link
Member

No description provided.

@osvaldot osvaldot requested a review from andypanix June 11, 2024 16:10
@osvaldot osvaldot force-pushed the 0000-add-cloud-sql-monitors branch from e9b2b87 to 0ae608f Compare June 17, 2024 12:59
README.md Outdated

This project can be used as a template for the initial stub of a Terraform
module.
This module creates a set of monitoring for Google Cloud Platform services.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This module creates a set of monitoring for Google Cloud Platform services.
This module creates a set of monitoring alerts for Google Cloud Platform services.

cloud-sql.tf Outdated

display_name = "${local.cloud_sql_project} ${each.value.instance} - Memory utilization ${each.value.severity} ${each.value.threshold * 100}%"
combiner = "OR"
# Available severity levels: INFO, WARNING, ERROR, CRITICAL, available from google provider >= 5.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Available severity levels: INFO, WARNING, ERROR, CRITICAL, available from google provider >= 5.0
# @TODO: restore severity after all projects are migrated to google provider 5.x. Actually, we cannot set severity since zambon-ops is using a 4.x version.

cloud-sql.tf Outdated

display_name = "${local.cloud_sql_project} ${each.value.instance} - Disk utilization ${each.value.severity} ${each.value.threshold * 100}%"
combiner = "OR"
# Available severity levels: INFO, WARNING, ERROR, CRITICAL, available from google provider >= 5.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Available severity levels: INFO, WARNING, ERROR, CRITICAL, available from google provider >= 5.0
# @TODO: restore severity after all projects are migrated to google provider 5.x. Actually, we cannot set srverity since zambon-ops is using a 4.x version.

@osvaldot osvaldot force-pushed the 0000-add-cloud-sql-monitors branch from 0ae608f to 900d387 Compare June 17, 2024 16:51
Copy link
Member

@andypanix andypanix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@andypanix andypanix merged commit cd804b2 into main Jun 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants