Refactor: board integrate #382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
000wan
reviewed
May 23, 2023
src/components/ThePostWrite.vue
Outdated
| <option | ||
| v-if="boardId" | ||
| value="" | ||
| :selected="categoryId = ''" |
There was a problem hiding this comment.
이거 왜 고장났지 했는데 = 1개 써서 그런것 같아요
:selected="categoryId === ''"로 바꾸면 작동은 합니다만 board 바꿀때 '말머리 없음'이 아니라 공백이 보입니다.
그래서 이 줄 그냥 삭제하고, 204번째 줄 watch 속성에
watch: {
boardId () {
if (this.categoryList.length) {
this.categoryId = '$not-set'
} else {
this.categoryId = ''
}
}
},boardId 바뀔 때마다 categoryId=$not-set으로 해주는데 이거를
boardId () {
this.categoryId = ''
}로 바꾸면 제대로 작동하는 듯 합니다.
src/components/TheNavbar.vue
Outdated
| @@ -287,14 +313,15 @@ export default { | |||
| changeLocale, | |||
| ...mapActions(['toggleDarkMode']), | |||
| click (boardName) { | |||
| if (this.boardGroup[boardName]) { | |||
| this.boardGroup[boardName] = false | |||
| console.log(this.boardList) | |||
There was a problem hiding this comment.
Suggested change
| console.log(this.boardList) |
console.log 삭제해주세요
| :key="groupName" | ||
| class="navbar-item has-dropdown is-hoverable boardlist" | ||
| v-for="group in boardGroup" | ||
| :key="group.name" |
There was a problem hiding this comment.
여기서 div 박스들 class가 좀 꼬여서 상단 아이템 hover 했을 때 밑에 빨간 바가 안나옵니다. (전체보기는 나옴)
git diff가 너무 길어서 일단 이 PR에 해당 버그 수정해서 커밋했어요. 작업 하던거 있으면 git pull --rebase 받고 해주세요!
integrate talk board
add anonymous button to postwrite
change the order of boards in navbar
change groupId
navbar 하드코딩 제거
delete console.log
change default category to 'no-category' change order of buttons
Co-authored-by: YoungWan Kweon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
잡담 게시판(Q&A, 자유게시판, 익명) -> 자유게시판으로 통합