-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Update matrix-appservice-irc
version
#3512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
# Config for the media proxy, required to serve publically accessible URLs to authenticated Matrix media | ||
mediaProxy: | ||
# To generate a .jwk file: | ||
# $ node src/generate-signing-key.js > signingkey.jwk | ||
signingKeyPath: "signingkey.jwk" | ||
# How long should the generated URLs be valid for | ||
ttlSeconds: 3600 | ||
# The port for the media proxy to listen on | ||
bindPort: 11111 | ||
# The publically accessible URL to the media proxy | ||
publicUrl: "https://irc.bridge/media" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These lines require some more setup
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, we can generate a signing key using the image with:
docker run --entrypoint node matrixdotorg/matrix-appservice-irc ./lib/generate-signing-key.js
We'll need to execute this command before starting the service, and allow the user to configure the parameters above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My questions are more about how bindPort
and publicUrl
should work: I'm not sure where to get these values from.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What I'm assuming right now is that:
bindPort
represents the internal port where the service will listen for connections. It won't be accessible from the internet.publicUrl
is the actual URL where external clients will go to fetch media. There must be some kind of reverse proxy redirecting requests from/topublicUrl
tobindPort
.
I may be wrong, though. I haven't been able to find good documentation on what these settings do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was under the impression that the media proxy was external to the bridge, but I might also be wrong there...
Setting up media proxy is a bit above my level |
I have rebased this, but would appreciate some help getting the authenticated media set up correctly |
The update to
3.0
brings with it that it now uses MediaProxy.