EX-2549 Address upstream comments #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Key name change from vmuid to vmcid * Change the userId key name to vmconnectid * Support new key in response payload + remain backward compatible. Co-authored-by: slimkrazy <[email protected]>
* add tagid to banner request * bump version * update test case * run tests Co-authored-by: John Salis <[email protected]>
* follow spec to parse fpd * ad unit support stub * adunit method * ad unit etc * typo * fix test * typo * change to const
|
Relevant changes are only in |
cpabst
approved these changes
Dec 10, 2020
| @@ -9,7 +9,7 @@ import { Renderer } from '../src/Renderer.js'; | |||
| export const storage = getStorageManager(); | |||
|
|
|||
| const BIDDER_CODE = 'jixie'; | |||
| const EVENTS_URL = 'https://jxhbtrackers.azurewebsites.net/sync/evt?'; | |||
| const EVENTS_URL = 'https://hbtra.jixie.io/sync/hb?'; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Address the comments from the upstream PR