Mark FlutterELinuxEngine as an unsafe reference for importing into Swift #432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhoward
force-pushed
the
lhoward/swift-engine-ref
branch
8 times, most recently
from
04db657 to
3f13bee
Compare
…egistrar as unsafe references for importing into Swift, consolidating Swift annotation macro wrappers into flutter_export.h. This patch allows the importing of C++ engine APIs into Swift, using the Swift C++ bridging layer. Signed-off-by: Luke Howard <[email protected]>
lhoward
force-pushed
the
lhoward/swift-engine-ref
branch
from
3f13bee to
4e74bab
Compare
|
Thank you for approving this. Being able to call the C++ API directly will be very useful for APIs that aren't yet exposed by C, and also lets us directly integrate Swift reference counting where applicable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch allows the importing of C++ engine APIs into Swift, using the Swift C++ bridging layer.
This fix is useful for FlutterSwift, and shouldn't be intrusive to non-Swift use cases. I appreciate that this patch lack general utility and I am prepared to maintain a fork if required, but hope you can see the value in merging it.