Update README adapt to Rails 6 [skip ci] #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soartec-lab
force-pushed
the
task/update_readme_adapt_to_rails_6
branch
from
4a32288 to
06f7346
Compare
|
FYI the section for Rails 5 was added in #6 since at that time Rails 5.0.0 have the race condition #5 (comment). That was already fixed by rails/rails#27057 and backported rails/rails@fd21a57 in Rails 5.0.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, thank you for developing a great gem
Summary
In the change from rails5 to rails6,
There were no changes to the
ActiveRecord::Base.clear_all_connections!andActiveRecord::Base.clear_active_connections!ActiveRecord methods called in this gem.See: https://github.com/rails/rails/blame/e00f9c8aaea3fbedc2d19926da4f4575c12f0aaa/activerecord/lib/active_record/connection_adapters/abstract/connection_pool.rb
Therefore, I added to README that this gem works on rails6.
could you verification?