sonic-wpasupplicant changes for PAC #88
Conversation
|
Below are the associated PRs for this functionality. #88 HLD PR is below we will raise the remaining functionality in new PRs asap. |
|
/azpw run Azure |
|
/AzurePipelines run Azure |
|
No pipelines are associated with this pull request. |
|
@jeff-yin @ridahanif96 pls help review |
|
/azpw run Azure |
|
/AzurePipelines run Azure |
|
No pipelines are associated with this pull request. |
| @@ -82,6 +85,9 @@ enum { RADIUS_ATTR_USER_NAME = 1, | |||
| RADIUS_ATTR_ACCT_OUTPUT_GIGAWORDS = 53, | |||
| RADIUS_ATTR_EVENT_TIMESTAMP = 55, | |||
| RADIUS_ATTR_EGRESS_VLANID = 56, | |||
| #ifdef CONFIG_SONIC_RADIUS | |||
There was a problem hiding this comment.
Does this need to be in the middle? can't we move all new enums at the end?
There was a problem hiding this comment.
RADIUS_ATTR_EGRESS_VLANID = 56,
#ifdef CONFIG_SONIC_RADIUS
RADIUS_ATTR_CHAP_CHALLENGE = 60,
#endif
The attribute value is 60. Hence the same is placed in the middle due to its numbering sequence. Same is the case with others.
| @@ -1728,3 +1751,420 @@ int radius_gen_session_id(u8 *id, size_t len) | |||
| */ | |||
| return os_get_random(id, len); | |||
| } | |||
|
|
|||
| #ifdef CONFIG_SONIC_RADIUS | |||
|
|
|||
There was a problem hiding this comment.
Can this SONiC specific code changes be moved to new file or patch file?
There was a problem hiding this comment.
Agree. It's a valid comment. Will take this as an future item. For now, we intend to keep the changes as is.
|
@Pterosaur code PR has been approved by PENS WG members, pls help merge |
src/radius/radius.h
Outdated
| @@ -124,7 +133,11 @@ enum { RADIUS_ATTR_USER_NAME = 1, | |||
| #define RADIUS_TERMINATION_ACTION_RADIUS_REQUEST 1 | |||
|
|
|||
| /* NAS-Port-Type */ | |||
| #ifdef CONFIG_SONIC_RADIUS | |||
| #define RADIUS_NAS_PORT_TYPE_IEEE_802_11 15 | |||
There was a problem hiding this comment.
IEEE 802.11 standard wireless interface has NAS port type as 19, and for "Ethernet" interface its 15, can we have the below instead "ifdef -else" block"
#ifdef CONFIG_SONIC_RADIUS
#define RADIUS_NAS_PORT_TYPE_ETHERNET 15
#endif
There was a problem hiding this comment.
addressed the comment
vijaya-ops
force-pushed
the
community_changes_pac
branch
from
12bdc0a to
46c62e0
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Hi @liushilongbuaa , do you know why the CI is failed? |
|
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@Pterosaur please help review and merge this PR |
Why I did it
The PAC functionality uses radius client that is in wpa supplicant for both 802.1X and MAB. These changes are done to achieve the same.
How I did it
How to verify it