Skip to content

[config] Add 'config interface mtu' command #793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 20, 2020
Merged

[config] Add 'config interface mtu' command #793

merged 1 commit into from
Feb 20, 2020

Conversation

okuzovych
Copy link
Contributor

- What I did
Implemented config interface mtu subcommand.

- How I did it

  1. Implemented mtu() method in config/main.py for parsing MTU parameter.
  2. Updated scripts/portconfig to enable correct hadling of MTU value.

- How to verify it

  1. Use config interface mtu command to set MTU on any Ethernet interface.
  2. Use show interfaces status to whether the MTU value of the port has changed in the database.
  3. Use ifconfig to check if the MTU change has been correcly handled by a subscriber.

- Usage example

admin@sonic:~$ sudo config interface mtu Ethernet64 1500

@msftclas
Copy link

msftclas commented Jan 29, 2020 •
edited
Loading

CLA assistant check
All CLA requirements met.

@okuzovych okuzovych requested a review from jleveque January 29, 2020 09:09
@lguohan
Copy link
Contributor

lguohan commented Jan 29, 2020

retest this please

@jleveque
Copy link
Contributor

jleveque commented Jan 30, 2020 •
edited
Loading

@prsunny to review, also.

@jleveque jleveque requested a review from prsunny January 30, 2020 00:51
jleveque
jleveque suggested changes Jan 30, 2020
View reviewed changes
@prsunny
Copy link
Contributor

prsunny commented Feb 12, 2020

Changes for mtu looks good to me. Please address other open comments.

@okuzovych
Copy link
Contributor Author

Changes for mtu looks good to me. Please address other open comments.
@prsunny Could you please review that comment? imho the requested changes to the doc should be addressed globally as a separate commit. The key point of the current commit is to implement config interface mtu parameter setting. So if you consider it ok, than it makes sence to apply changes and to improve the doc in the next step.

@jleveque jleveque merged commit caa2773 into sonic-net:master Feb 20, 2020
abdosi pushed a commit that referenced this pull request Jul 26, 2020
@okuzovych @abdosi
[config] Add 'config interface mtu' command (#793)
5243cc5
abdosi pushed a commit to abdosi/sonic-utilities that referenced this pull request Aug 4, 2020
@okuzovych @abdosi
[config] Add 'config interface mtu' command (sonic-net#793)
18d2c65
stepanblyschak pushed a commit to stepanblyschak/sonic-utilities that referenced this pull request Apr 28, 2022
@abdosi
[submodule update] sonic-utilities
940e5c0 
[config] Add 'config interface mtu' command sonic-net#793
add fec configuration 'config interface fec [OPTIONS] <interface_name>
<interface_fec>' sonic-net#764
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andriymoroz andriymoroz andriymoroz left review comments

@jleveque jleveque jleveque approved these changes

@prsunny prsunny prsunny approved these changes

Assignees
No one assigned
Labels
Enhancement Included in 201911 Branch Request for 201911 Branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@okuzovych @msftclas @lguohan @jleveque @prsunny @andriymoroz @abdosi