Skip to content

[show] Add 'features' subcommand to display status for optional features #712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 26, 2019

Conversation

pra-moh
Copy link
Contributor

@pra-moh pra-moh commented Oct 22, 2019

- What I did
Added 'show features' command to show status of an optional feature
- How I did it

- How to verify it
run 'show features'

Feature    Status
---------  --------
telemetry  enabled

- Previous command output (if the output of a command-line utility has changed)

- New command output (if the output of a command-line utility has changed)

-->

@jleveque jleveque changed the title adding show features command to see status for optional features [show] Add 'features' subcommand to display status for optional features Oct 22, 2019
@jleveque
Copy link
Contributor

Retest this please

@hui-ma hui-ma self-requested a review October 25, 2019 22:11
Copy link
Contributor

@hui-ma hui-ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hui-ma
Copy link
Contributor

hui-ma commented Oct 25, 2019

@jleveque Pleease help check the build error and suggest how to redo the check

@jleveque
Copy link
Contributor

Retest this please

1 similar comment
@jleveque
Copy link
Contributor

Retest this please

@jleveque jleveque merged commit f51544a into master Nov 26, 2019
@qiluo-msft qiluo-msft deleted the add-show-features branch July 22, 2020 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants