remove quagga for bgp show cli #3982
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
lipxu
changed the title
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
BYGX-wcr
reviewed
Jul 25, 2025
|
|
||
| return result | ||
|
|
||
| return "frr" |
There was a problem hiding this comment.
Can we move the get_routing-stack function to utilities_common?
BYGX-wcr
reviewed
Jul 25, 2025
| @@ -88,17 +88,7 @@ | |||
| # location (configdb?), so that we prevent the continous execution of this | |||
| # bash oneliner. To be revisited once routing-stack info is tracked somewhere. | |||
| def get_routing_stack(): | |||
There was a problem hiding this comment.
If we directly return frr, the show ip bgp command will become callable on any SONiC device even if the BGP container is not running on that device. This is different than before. For example, on the DPUs of smartswitches, are show ip bgp commands valid to execute?
There was a problem hiding this comment.
Good point, thanks for reminder, let me check it first. thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
The PR #3960 check the docker container's name.
Check the docker's name whether is exactly same with "bgp"
However, on multiple asic devices, there are several bgp containers, and named bgp0, bgp1 ....
How I did it
In master, return frr directly since there would no quagga in new release version and Remove quagga related UT code
How to verify it
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)