Disable routeCheck monit as part of config reload/minigraph stop service and enable it back as part of service start. #3682
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Abhishek Dosi <[email protected]>
with large route scale of 70K+ routes this can log monit error Transiently which can also fail in sonic-mgmt. Signed-off-by: Abhishek Dosi <[email protected]>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@anamehra @yejianquan for viz. |
abdosi
changed the title
Signed-off-by: Abhishek Dosi <[email protected]>
|
/azp run Azure.sonic-utilities |
|
Azure Pipelines successfully started running 1 pipeline(s). |
anamehra
reviewed
Dec 16, 2024
| try: | ||
| subprocess.check_call(['sudo', 'monit', 'status'], stdout=subprocess.DEVNULL, stderr=subprocess.DEVNULL) | ||
| click.echo("Enabling container monitoring ...") | ||
| click.echo("Enabling container and routeCheck monitoring ...") |
There was a problem hiding this comment.
After the route check is enabled at this point, as the links and sessions are still coming up, it may still cause same error if a route check happens, is that correct?
There was a problem hiding this comment.
@anamehra once we have start of monit probability of hitting ERR is less since it takes 5 min for monit to initialize and then we have 15 min (3 cycle) for any error to come. System should get stabilize by 15-20 min post monit restart.
anamehra
approved these changes
Dec 17, 2024
|
@yejianquan : Help with cherry-pick |
liushilongbuaa
added
Approved for 202405 Branch
and removed
Approved for 202405 Branch
labels
mssonicbld
pushed a commit
to mssonicbld/sonic-utilities
that referenced
this pull request
Dec 18, 2024
…ice and enable it back as part of service start. (sonic-net#3682) What I did: For Config reload/minigraph stop and re-enable routeCheck because with large route scale of 70K+ routes this can log monit error Transiently which can result in failure of sonic-mgmt test cases because of loganalyzer. Why I did: Because of this transient issue monit ERR log can get generated and this can result failure of sonic-mgmt test case. How I verify: Manual Verification via sudo monit status routeCheck and UT updated.
|
Cherry-pick PR to 202405: #3686 |
mssonicbld
pushed a commit
that referenced
this pull request
Dec 18, 2024
…ice and enable it back as part of service start. (#3682) What I did: For Config reload/minigraph stop and re-enable routeCheck because with large route scale of 70K+ routes this can log monit error Transiently which can result in failure of sonic-mgmt test cases because of loganalyzer. Why I did: Because of this transient issue monit ERR log can get generated and this can result failure of sonic-mgmt test case. How I verify: Manual Verification via sudo monit status routeCheck and UT updated.
mssonicbld
added
Included in 202405 Branch
and removed
Created PR to 202405 Branch
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did:
For Config reload/minigraph stop and re-enable routeCheck because
with large route scale of 70K+ routes this can log monit error
Transiently which can result in failure of sonic-mgmt test cases because of loganalyzer.
MSFT ADO: 30457854
Why I did:
Because of this transient issue monit ERR log can get generated and this can result failure of sonic-mgmt test case.
How I verify:
Manual Verification via
sudo monit status routeCheckand UT updated.