Speed up route_check script #3678
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Sonic-buildimage PR checker Passes now.. sonic-net/sonic-buildimage#21145 |
|
MSFT ADO: 30169130 |
arlakshm
approved these changes
Dec 13, 2024
deepak-singhal0408
added
Included in 202405 Branch
and removed
Request for 202405 Branch
labels
kperumalbfn
added
Request for 202411 Branch
and removed
Request for 202411 Branch
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
This PR fixes sonic-net/sonic-buildimage#18773 and sonic-net/sonic-buildimage#20648
Note: resubmitting the Old PR #3544 (with minor cosmetic changes). The original PR was reverted due to PR check failure. The failure has been root caused and fixed via sonic-net/sonic-mgmt#16013
How I did it
Parallely execute route_check on each Asic.
Parallelly fetch ipv4 routes and ipv6 routes.
How to verify it
execute "time route_check.py" on T2 chassis having 32k v4+32k v6 routes.
Results:
Before:
Checking routes for namespaces: ['asic0', 'asic1']
real 3m16.387s
user 1m26.084s
sys 0m7.275s
After:
time route_check.py
real 1m30.675s
user 1m33.777s
sys 0m8.209s
Previous command output (if the output of a command-line utility has changed)
None
New command output (if the output of a command-line utility has changed)
None