Fix multi-asic behaviour for PFC #3520
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change puts contents originally in pfc/main.py into a class, to support the usage of the multi-asic helper in a future change. This change is required, as multi-asic helper relies on certain members of the class to exist. The multi-asic class helper will be used to add multi-asic support to pfc commands.
Removed the use of the environment variable to test `config asymmetric on`. Instead replaced the validation method with a direct check for the expected CONFIG_DB entry. Also removed the unnecessary classmethods in TestPfcBase.
- Add multi-asic support for pfc show and config methods - Replace DB file with JSON for unit test - Add unit tests for multi-asic pfc support - Add a test vector file for better testcase organization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Added multi-asic support to PFC by:
This is a logical successor of #3057 and is a part of the larger efforts to add multi-asic functionality tracked in #15148
How I did it
I used the multi_asic helper functions from
sonic_py_commonandutilities_commonto handle multiple namespacesHow to verify it
There were three stages of verification:
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)
The namespace argument is the new addition to the pfc command.
Case 1: If namespace is specified in a multi-asic device
Behaviour: We will run the command only on the specified namespace
e.g:
pfc show asymmetric --namespace asic0Case 2: If no namespace is specified in a multi-asic device
Behaviour: We will run the command on all namespaces
e.g:
pfc show priorityCase 3: If a namespace is specified in single-asic device (other than default '')
Behaviour: We will raise an invalid argument error
e.g:
pfc show asymmetric --namespace asic0Case 4: If no namespace is specified in single-asic device
Behaviour: We will run it on the only valid namespace - default namespace
e.g:
pfc show priority