Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLI support for SmartSwitch PMON #3271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI support for SmartSwitch PMON #3271
Changes from 177 commits
11cc04d
02df0ea
e0e4700
0a8fc5a
6d61faa
8d95dae
5c1b666
fe4a8cf
f896438
9d6c093
0904515
ccc380b
a8fa81d
1cf96a0
64fd559
d202e1c
b8c92ae
9986f7b
0dc52f6
93df26d
7a2aaf4
26f9b8a
3a592f8
71472a8
fd8bd6b
5b15bc4
b35c987
ee10649
27546a6
883e35c
713ffa2
62fc3d0
ecb2ecc
e2eb660
ef87cb5
53c2277
fb989e4
8ea7960
76de68a
a08e0cb
766b303
c474940
1910163
851dc78
cb54b73
4dfb5f8
6941baf
f3c8e36
6d7d539
433bc50
3ddcc9c
95da5c0
627dd5e
934e6ef
64d06ec
4870a86
fed3f67
68b6416
d229307
78e71c5
d7fbe9d
313a9d2
0ea1227
f5f88bb
62817ea
9fb005d
7c8c5d7
b5b068b
25259cb
808e7b4
7eb8304
44bed5c
d7fd0ce
b0e51f8
ed742fc
11f48f3
402887d
8db11f3
2ab48b5
e843fff
9ba21d2
738634d
c491687
ee3f927
d47a431
04c520e
c5abc01
6ab7742
4299ac3
d30ead7
a07e8c0
a2cece6
e2b65af
53909f0
9849436
02152e3
a75a4d3
f8a1f57
29000c3
e273a16
d720cf6
c6040b3
864c96c
8580f76
f4942b7
3e44844
e7355b0
b132f90
781270a
2e8813b
6cba5ed
5db0bc2
807529f
885b168
b6efa8c
4c26a25
ed3d24b
68a9efe
d09d58f
c217c18
df87438
2dfc2b5
c261b0c
ab200bc
5e36792
4a43780
8b2c9cb
155ba3f
e8c8b42
9601177
9713bf7
fdf8569
4b30138
e725add
d2e7590
3e1fc12
51dce03
a016ead
041fad6
5c85cf4
1b3fabb
9a0225b
8f191d6
523a42c
a90b878
594a9dc
79666d1
9bb29e3
63d5f9f
1255ee6
d630304
933c04e
5a4c7fd
989fa80
00df371
48c8419
be8d747
0764a34
54cfbab
00c0ee0
b43f72b
ec47fa2
8432ed8
df2517b
d30b4fb
3274de0
c53685f
2b77e74
d46bf3a
513f21d
8da07e1
6796e67
e89daf7
2ccb4c3
d0f02f7
8b86eee
4ed816f
ea76bf3
3c3a500
3837515
9d94a9a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to perform additional validation to check if the chassis_module_name is actually present (or is an actual valid module name) or not, if user executes
config chassis modules startup DPU5
on a system which does not have DPU5, this will cause crash in chassisd for theSmartSwitchConfigManagerTask
in chassisd preventing further startup or shutdown calls (even though output of the command would beStarting up chassis module DPU1
orShutting down chassis module DPU1
the only operation which is performed is addition/removal from the CONFIG_DB )There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gpunathilell Added
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rameshraghupathy in all these sample examples can you specify where the CLI is being executed. NPU or in the DPU host.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@prgeor Added samples, in missing places
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rameshraghupathy please also capture the CLI output specifically when run inside DPU (even though its same as fixed chassis)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@prgeor Added the CLI output when run on DPU
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rameshraghupathy This will list the DPUs that are in admin shut?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. This will show the "show reboot-cause" output of the DPUs that are admin UP.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@prgeor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rameshraghupathy is this still true? With new design change, NPU can still find the last reboot cause of the DPU irrespective of its ADMIN state.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rameshraghupathy could you address Prince comment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@prgeor With the new design NPU can still find the last reboot cause of the DPU irrespective of its ADMIN state.
@vvolam Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add sample outputs for system-health as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gpunathilell Done