-
Notifications
You must be signed in to change notification settings - Fork 710
Add sonic-clear logging command #3151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
matiAlfaro
wants to merge
6
commits into
sonic-net:master
Choose a base branch
from
Marvell-sonic:add_sonic_clear_command
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
95e8a5e
add sonic-clear logging command
matiAlfaro 2f1ebdf
remove unused code
matiAlfaro 88a36d4
add tests
matiAlfaro 7abf614
Update clear_test.py
matiAlfaro 5bc37e6
handle both /var/log and /var/log.tmpfs
matiAlfaro 1bd327a
Check the /var/log/ exists
matiAlfaro File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,6 +3,7 @@ | |
import subprocess | ||
import sys | ||
import click | ||
import glob | ||
import utilities_common.cli as clicommon | ||
import utilities_common.multi_asic as multi_asic_util | ||
from sonic_py_common.general import getstatusoutput_noshell_pipe | ||
|
@@ -545,6 +546,28 @@ def route(prefix, vrf, namespace): | |
command += ['-n', str(namespace)] | ||
clicommon.run_command(command) | ||
|
||
@click.option('--all', '-a', is_flag=True, help='Delete also compressed logs') | ||
@cli.command() | ||
def logging(all): | ||
"""Clear logging files""" | ||
log_path_arr = ["/var/log"] | ||
if os.path.exists("/var/log.tmpfs"): | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do we not plan to delete existing logs in There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, thanks. |
||
log_path_arr += ["/var/log.tmpfs"] | ||
|
||
files_to_delete=[] | ||
for log_path in log_path_arr: | ||
if all: | ||
files_to_delete += glob.glob(f"{log_path}/syslog*") | ||
else: | ||
if os.path.isfile(f"{log_path}/syslog"): | ||
files_to_delete += [f"{log_path}/syslog"] | ||
if os.path.isfile(f"{log_path}/syslog.1"): | ||
files_to_delete += [f"{log_path}/syslog.1"] | ||
|
||
for f in files_to_delete: | ||
cmd = ['sudo', 'rm','-f',f] | ||
run_command(cmd) | ||
|
||
|
||
# Load plugins and register them | ||
helper = util_base.UtilHelper() | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we put a check here to ensure
/var/log
directory exists before settinglog_path_arr
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done