Skip to content

[scripts/generate_dump] add information to tech-support file #2357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 31, 2022

Conversation

LimorAmit
Copy link
Contributor

What I did

I added/extended some commands of the generate_dump script to collect more information about the system and processes.
In addition, I removed some errors when trying to remove files that don't exist.

How I did it

create new function and add new calls for commands to get more information.
Regarding the error messages - I checked before removing the files and remove with force parameter.

How to verify it

verified that the new files and information are part of the dump

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 7, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

@volodymyrsamotiy
Copy link
Collaborator

@LimorAmit, could you please update PR title according to contribution guide described in README?
It should be aligned with the following format: [component/folder touched]: Description intent of your changes.

@LimorAmit LimorAmit changed the title Dump ext [scripts/generate_dump] add information to tech-support file Oct 11, 2022
Copy link
Contributor Author

@LimorAmit LimorAmit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed review comments

Copy link
Contributor Author

@LimorAmit LimorAmit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed comment

@qiluo-msft qiluo-msft merged commit 40cc8e1 into sonic-net:master Oct 31, 2022
preetham-singh pushed a commit to preetham-singh/sonic-utilities that referenced this pull request Nov 21, 2022
…et#2357)

#### What I did
I added/extended some commands of the generate_dump script to collect more information about the system and processes.
In addition, I removed some errors when trying to remove files that don't exist.

#### How I did it
create new function and add new calls for commands to get more information.
Regarding the error messages - I checked before removing the files and remove with force parameter.
 
#### How to verify it
verified that the new files and information are part of the dump
mdanish-kh pushed a commit to mdanish-kh/sonic-utilities that referenced this pull request Nov 23, 2022
…et#2357)

#### What I did
I added/extended some commands of the generate_dump script to collect more information about the system and processes.
In addition, I removed some errors when trying to remove files that don't exist.

#### How I did it
create new function and add new calls for commands to get more information.
Regarding the error messages - I checked before removing the files and remove with force parameter.
 
#### How to verify it
verified that the new files and information are part of the dump
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants